Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errbot, or Slack, is URI encoding special characters like "greater than" #1246

Open
1 of 5 tasks
lingfish opened this issue Aug 12, 2018 · 1 comment
Open
1 of 5 tasks

Comments

@lingfish
Copy link

In order to let us help you better, please fill out the following fields as best you can:

I am...

  • Reporting a bug
  • Suggesting a new feature
  • Requesting help with running my bot
  • Requesting help writing plugins
  • Here about something else

I am running...

  • Errbot version: 5.2.0
  • OS version: Debian Stretch
  • Python version: 3.6.4
  • Using a virtual environment: yes

Issue description

When using the configuration system, it seems that data being stored is being URI encoded by either the bot, or Slack (eg "greater than" > is being stored as ">".

Steps to reproduce

Setup a basic config dict, and then attempt to store the string "123>456".

When querying that back, it appears to be right in the Slack client, but when I use that field for say, a password, and send that to an external API, it sends > instead.

You can see this with a quick self.log call within plugin code.

@lingfish
Copy link
Author

lingfish commented Aug 13, 2018

I just found #964 which seems to be related.

I think the only way around this until devs have a better idea, is for the user to have to supply (for example) a base64 encoded string, and unwrap it in the plugin.

As I think of that suggestion a little more, even the trailing equals may still get mangled :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants