Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about deprepcated build options #331

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

starbelly
Copy link
Member

We will continue to allow include_files and exclude_regexps for some time, yet we need to steer people further from these options and towards include_paths and exclude_paths (including myself 😛) loudly.

Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor language tweaks, but I assume you'll know better than me 😄

src/rebar3_hex_build.erl Outdated Show resolved Hide resolved
src/rebar3_hex_build.erl Outdated Show resolved Hide resolved
@starbelly
Copy link
Member Author

Minor language tweaks, but I assume you'll know better than me 😄

I made one more tweak, which was to remove the 's. It's confusing, but an object can not have a possessive form.

@starbelly starbelly merged commit 9412b5c into main Oct 16, 2023
2 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the warn-about-include-files-and-exclude_regexps branch October 16, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants