Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wx: add support for ARM64 Windows #8990

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

cocoa-xu
Copy link
Contributor

This PR is one of the smaller PRs separated from the original PR #8142 that attempts to add initial support for ARM64 windows, and hopefully, this should be the last technical one 🤞

wxWidgets produces static libs for ARM64 in the vc_arm64_lib directory with the following command

nmake TARGET_CPU=arm64 BUILD=release SHARED=0 DIR_SUFFIX_CPU= -f makefile.vc

So we only need a tiny tweak to make it work:

Screenshot 2024-10-27 002355

Copy link
Contributor

github-actions bot commented Oct 26, 2024

CT Test Results

  2 files   17 suites   5m 44s ⏱️
155 tests 150 ✅ 5 💤 0 ❌
171 runs  166 ✅ 5 💤 0 ❌

Results for commit 78b2729.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@rickard-green rickard-green added the team:PS Assigned to OTP team PS label Oct 28, 2024
@dgud dgud added the testing currently being tested, tag is used by OTP internal CI label Nov 26, 2024
@dgud dgud self-requested a review November 26, 2024 08:48
@dgud dgud merged commit 3e679a5 into erlang:master Nov 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants