Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApolloDiagnostic -> GraphQLError Conversion #2

Open
erikwrede opened this issue Jan 29, 2023 · 0 comments
Open

ApolloDiagnostic -> GraphQLError Conversion #2

erikwrede opened this issue Jan 29, 2023 · 0 comments

Comments

@erikwrede
Copy link
Owner

erikwrede commented Jan 29, 2023 •
edited
Loading

When the compiler returns diagnostics after validation, they should be converted to a spec-compliant GQLError. We need to make sure only critical diagnostics, not warnings are returned in the errors list.

Blocked by apollographql/apollo-rs#423
Explore how to extract the necessary info from the new ariadne interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikwrede