Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash function works directly on utf8 string with charCodeAt that may return values greater than 256 #8

Open
ozomer opened this issue Sep 9, 2019 · 0 comments
Open

Hash function works directly on utf8 string with charCodeAt that may return values greater than 256 #8

ozomer opened this issue Sep 9, 2019 · 0 comments

Comments

@ozomer
Copy link

ozomer commented Sep 9, 2019

I don't think that the original djb hash function was intended to work on arrays with values > 256.
Best solution is to convert the key to a buffer first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ozomer