From efd6b8898a18ed718a1ca3aa96c25be26975fc37 Mon Sep 17 00:00:00 2001
From: Eric Cornelissen <ericornelissen@gmail.com>
Date: Sun, 30 Jun 2024 23:23:57 +0200
Subject: [PATCH] Upgrade to `pp-test-kit@0.1.2` (#1614)

Upgrade the pp-test-kit dependency and use the new simulate API in tests
that test behavior under the effect of a specific polluted property.
---
 package-lock.json                       | 8 ++++----
 package.json                            | 2 +-
 test/unit/executables/resolve.test.js   | 7 ++++++-
 test/unit/platforms/get-helpers.test.js | 7 ++++++-
 test/unit/win/index.test.js             | 7 ++++++-
 5 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 0cf4a65d8..1d0d2580b 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -36,7 +36,7 @@
         "lockfile-lint": "4.13.1",
         "markdownlint-cli": "0.40.0",
         "nve": "18.0.0",
-        "pp-test-kit": "0.1.1",
+        "pp-test-kit": "0.1.2",
         "prettier": "3.2.4",
         "publint": "0.2.8",
         "rollup": "4.18.0",
@@ -11390,9 +11390,9 @@
       }
     },
     "node_modules/pp-test-kit": {
-      "version": "0.1.1",
-      "resolved": "https://registry.npmjs.org/pp-test-kit/-/pp-test-kit-0.1.1.tgz",
-      "integrity": "sha512-1Ev5or1EJYSE2/pTQb+EBNWgSlr6ojpYozViuNxsXUEGjRdYZH7mVFM0TTlfRa4xVGfrd5fgCOOcVzhbDQ6wKg==",
+      "version": "0.1.2",
+      "resolved": "https://registry.npmjs.org/pp-test-kit/-/pp-test-kit-0.1.2.tgz",
+      "integrity": "sha512-VvNAa6ePrUFjtd+B9fa93EewP5Pf/d7wDTEd4E/WLVX0Uq3SfPFTh75bxmRIrfaty+yQzvMi+m3oS1xQbQvnvA==",
       "dev": true,
       "license": "ISC",
       "engines": {
diff --git a/package.json b/package.json
index a12a9bfe7..c4849a011 100644
--- a/package.json
+++ b/package.json
@@ -86,7 +86,7 @@
     "lockfile-lint": "4.13.1",
     "markdownlint-cli": "0.40.0",
     "nve": "18.0.0",
-    "pp-test-kit": "0.1.1",
+    "pp-test-kit": "0.1.2",
     "prettier": "3.2.4",
     "publint": "0.2.8",
     "rollup": "4.18.0",
diff --git a/test/unit/executables/resolve.test.js b/test/unit/executables/resolve.test.js
index bb0f9fa32..673bdce79 100644
--- a/test/unit/executables/resolve.test.js
+++ b/test/unit/executables/resolve.test.js
@@ -6,6 +6,7 @@
 import { testProp } from "@fast-check/ava";
 import test from "ava";
 import * as fc from "fast-check";
+import * as ppTestKit from "pp-test-kit/simulate";
 import sinon from "sinon";
 
 import { arbitrary } from "./_.js";
@@ -108,7 +109,11 @@ testProp(
 
     t.context.deps.which.resetHistory();
 
-    env = Object.assign(Object.create({ [pathName]: prototypePath }), env);
+    env = ppTestKit.simulatePollution({
+      subject: env,
+      property: pathName,
+      value: prototypePath,
+    });
 
     const { executable } = t.context;
     const args = { env, executable };
diff --git a/test/unit/platforms/get-helpers.test.js b/test/unit/platforms/get-helpers.test.js
index 527c485b4..2b4f896a3 100644
--- a/test/unit/platforms/get-helpers.test.js
+++ b/test/unit/platforms/get-helpers.test.js
@@ -6,6 +6,7 @@
 
 import { testProp } from "@fast-check/ava";
 import * as fc from "fast-check";
+import * as ppTestKit from "pp-test-kit/simulate";
 
 import { arbitrary, constants } from "./_.js";
 
@@ -81,7 +82,11 @@ testProp(
   (t, env, prototypeOstype, platform) => {
     fc.pre(![...winOsTypes].includes(env.OSTYPE));
 
-    env = Object.assign(Object.create({ OSTYPE: prototypeOstype }), env);
+    env = ppTestKit.simulatePollution({
+      subject: env,
+      property: "OSTYPE",
+      value: prototypeOstype,
+    });
 
     const result = getHelpersByPlatform({
       env,
diff --git a/test/unit/win/index.test.js b/test/unit/win/index.test.js
index 7c40f489c..1d04ec4bf 100644
--- a/test/unit/win/index.test.js
+++ b/test/unit/win/index.test.js
@@ -8,6 +8,7 @@ import path from "node:path/win32";
 import { testProp } from "@fast-check/ava";
 import test from "ava";
 import * as fc from "fast-check";
+import * as ppTestKit from "pp-test-kit/simulate";
 import sinon from "sinon";
 
 import { arbitrary, constants } from "./_.js";
@@ -61,7 +62,11 @@ testProp(
   (t, env, prototypeComSpec) => {
     fc.pre(env.ComSpec !== prototypeComSpec);
 
-    env = Object.assign(Object.create({ ComSpec: prototypeComSpec }), env);
+    env = ppTestKit.simulatePollution({
+      subject: env,
+      property: "ComSpec",
+      value: prototypeComSpec,
+    });
 
     const result = win.getDefaultShell({ env });
     t.not(result, prototypeComSpec);