From 4d9800716b863fad454097b71daf5c78aeb0e716 Mon Sep 17 00:00:00 2001
From: Shunsuke Shibayama <sbym1346@gmail.com>
Date: Thu, 25 May 2023 20:25:59 +0900
Subject: [PATCH] fix: eliminate `unwrap`s

---
 crates/erg_common/config.rs      |  4 +--
 crates/erg_common/env.rs         |  1 +
 crates/erg_common/python_util.rs | 49 ++++++++++++++++++--------------
 3 files changed, 30 insertions(+), 24 deletions(-)

diff --git a/crates/erg_common/config.rs b/crates/erg_common/config.rs
index ce415dd99..915a18875 100644
--- a/crates/erg_common/config.rs
+++ b/crates/erg_common/config.rs
@@ -460,7 +460,7 @@ impl Input {
         }
     }
 
-    pub fn sys_path(&self) -> Vec<PathBuf> {
+    pub fn sys_path(&self) -> Result<Vec<PathBuf>, std::io::Error> {
         get_sys_path(self.unescaped_path().parent())
     }
 
@@ -548,7 +548,7 @@ impl Input {
                 return Ok(path);
             }
         }
-        for sys_path in self.sys_path() {
+        for sys_path in self.sys_path()? {
             let mut dir = sys_path;
             dir.push(path);
             dir.set_extension("py");
diff --git a/crates/erg_common/env.rs b/crates/erg_common/env.rs
index 5f2446dbf..377496b4f 100644
--- a/crates/erg_common/env.rs
+++ b/crates/erg_common/env.rs
@@ -55,6 +55,7 @@ fn _erg_external_lib_path() -> PathBuf {
 }
 fn _python_site_packages() -> impl Iterator<Item = PathBuf> {
     get_sys_path(None)
+        .unwrap_or(vec![])
         .into_iter()
         .filter(|p| p.ends_with("site-packages"))
         .map(|p| {
diff --git a/crates/erg_common/python_util.rs b/crates/erg_common/python_util.rs
index 34b6e04a1..ee17bfbbb 100644
--- a/crates/erg_common/python_util.rs
+++ b/crates/erg_common/python_util.rs
@@ -531,26 +531,30 @@ pub const BUILTIN_PYTHON_MODS: [&str; 165] = [
     "zoneinfo",
 ];
 
-pub fn which_python() -> String {
+pub fn opt_which_python() -> Result<String, String> {
     let (cmd, python) = if cfg!(windows) {
         ("where", "python")
     } else {
         ("which", "python3")
     };
-    let out = Command::new(cmd)
-        .arg(python)
-        .output()
-        .unwrap_or_else(|_| panic!("{}: {python} not found", fn_name_full!()));
-    let res = String::from_utf8(out.stdout).unwrap();
+    let Ok(out) = Command::new(cmd).arg(python).output() else {
+        return Err(format!("{}: {python} not found", fn_name_full!()));
+    };
+    let Ok(res) = String::from_utf8(out.stdout) else {
+        return Err(format!("{}: failed to commnunicate with Python", fn_name_full!()));
+    };
     let res = res.split('\n').next().unwrap_or("").replace('\r', "");
     if res.is_empty() {
-        println!("{}: {python} not found", fn_name_full!());
-        std::process::exit(1);
+        return Err(format!("{}: {python} not found", fn_name_full!()));
     } else if res.contains("pyenv") && cfg!(windows) {
-        println!("cannot use pyenv-win"); // because pyenv-win does not support `-c` option
-        std::process::exit(1);
+        // because pyenv-win does not support `-c` option
+        return Err("cannot use pyenv-win".into());
     }
-    res
+    Ok(res)
+}
+
+fn which_python() -> String {
+    opt_which_python().unwrap()
 }
 
 pub fn detect_magic_number(py_command: &str) -> u32 {
@@ -690,10 +694,15 @@ pub fn env_python_version() -> PythonVersion {
     get_python_version(&which_python())
 }
 
-pub fn get_sys_path(working_dir: Option<&Path>) -> Vec<PathBuf> {
+pub fn get_sys_path(working_dir: Option<&Path>) -> Result<Vec<PathBuf>, std::io::Error> {
     let working_dir = fs::canonicalize(working_dir.unwrap_or(Path::new(""))).unwrap_or_default();
     let working_dir = remove_verbatim(&working_dir);
-    let py_command = which_python();
+    let py_command = opt_which_python().map_err(|e| {
+        std::io::Error::new(
+            std::io::ErrorKind::NotFound,
+            format!("cannot find python: {e}"),
+        )
+    })?;
     let code = "import os, sys; print('\\n'.join(map(lambda p: os.path.abspath(p), sys.path)))";
     let out = if cfg!(windows) {
         Command::new("cmd")
@@ -704,21 +713,17 @@ pub fn get_sys_path(working_dir: Option<&Path>) -> Vec<PathBuf> {
             .arg(py_command)
             .arg("-c")
             .arg(code)
-            .output()
-            .expect("cannot get the sys.path")
+            .output()?
     } else {
         let exec_command = format!("cd {working_dir} && {py_command} -c \"{code}\"");
-        Command::new("sh")
-            .arg("-c")
-            .arg(exec_command)
-            .output()
-            .expect("cannot get the sys.path")
+        Command::new("sh").arg("-c").arg(exec_command).output()?
     };
     let s_sys_path = String::from_utf8(out.stdout).unwrap();
-    s_sys_path
+    let res = s_sys_path
         .split('\n')
         .map(|s| PathBuf::from(s.trim().to_string()))
-        .collect()
+        .collect();
+    Ok(res)
 }
 
 /// executes over a shell, cause `python` may not exist as an executable file (like pyenv)