Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade otel #1074

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

ashnamehrotra
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: ashnamehrotra <[email protected]>
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.

Files Patch % Lines
...ollers/imagecollector/imagecollector_controller.go 0.00% 3 Missing ⚠️
pkg/metrics/metrics.go 76.92% 3 Missing ⚠️
controllers/imagelist/imagelist_controller.go 0.00% 2 Missing ⚠️
pkg/remover/remover.go 0.00% 2 Missing ⚠️
pkg/scanners/template/scanner_template.go 0.00% 2 Missing ⚠️
pkg/utils/utils.go 0.00% 2 Missing ⚠️
controllers/configmap/configmap.go 0.00% 1 Missing ⚠️
pkg/cri/client.go 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 4.38% <38.46%> (-10.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/configmap/configmap.go 0.00% <0.00%> (ø)
pkg/cri/client.go 0.00% <0.00%> (ø)
controllers/imagelist/imagelist_controller.go 1.58% <0.00%> (ø)
pkg/remover/remover.go 0.00% <0.00%> (ø)
pkg/scanners/template/scanner_template.go 0.00% <0.00%> (ø)
pkg/utils/utils.go 13.43% <0.00%> (+1.60%) ⬆️
...ollers/imagecollector/imagecollector_controller.go 1.12% <0.00%> (ø)
pkg/metrics/metrics.go 57.89% <76.92%> (+0.75%) ⬆️

... and 34 files with indirect coverage changes

Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
@ashnamehrotra ashnamehrotra marked this pull request as draft August 26, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant