Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saturation pressure and temperature calculation give inaccurate results #887

Open
EvenSol opened this issue Dec 21, 2023 · 0 comments
Open

Saturation pressure and temperature calculation give inaccurate results #887

EvenSol opened this issue Dec 21, 2023 · 0 comments
Assignees
@EvenSol

Comments

@EvenSol
Copy link
Collaborator

EvenSol commented Dec 21, 2023

Describe the bug
Saturation pressure temperature gives inaccurate results when comparing to phase envelope dew point pressure/temperature.
See #886

To Reproduce
Disable multiphase check in src/main/java/neqsim/PVTsimulation/simulation/SaturationPressure.java or src/main/java/neqsim/PVTsimulation/simulation/SaturationTemperature.java

Expected behavior
The calculated saturation pressure/temperature should be independent of if multiphasecheck is enabled or not.
@EvenSol EvenSol mentioned this issue Dec 21, 2023
Merged
@EvenSol EvenSol changed the title Saturation pressure temperature gives inaccurate results when comparing to phase envelope dew point pressure/temperature Saturation pressure temperature gives inaccurate results Dec 21, 2023
@EvenSol EvenSol changed the title Saturation pressure temperature gives inaccurate results Saturation pressure and temperature calculation give inaccurate results Dec 21, 2023
@EvenSol EvenSol self-assigned this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvenSol EvenSol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EvenSol