Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/chunkGettingPersonProfiles #591

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

aleklundeq
Copy link
Collaborator

@aleklundeq aleklundeq commented Sep 20, 2023

  • New feature
  • Bug fix
  • High impact

Description of work:
When getting PersonProfiles there is a limitation of 500 personIdentifiers at the time when requesting from PeopleAPI. The problem was identified when trying to access GetAllRequests from FRA.ApplicationManagement.
This change should be a workaround for getting more than 500 at the time so we get all the Requests.

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

The problem arosed in Production for FRA.Application Management because of the amount of requests we where trying to get. The tests should be to just get requests as normal. There should not be any changes other than the possibility to get more than 500 PersonProfiles at the time, which currently only applies to Production

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@aleklundeq aleklundeq marked this pull request as ready for review September 20, 2023 12:42
@aleklundeq aleklundeq merged commit 972bbe2 into master Sep 20, 2023
6 checks passed
@aleklundeq aleklundeq deleted the feat/ChunkGetttingPersonProfilesRequests branch September 20, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants