-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect backend and frontend to signalR #1041
Conversation
c08b2a8
to
4b24872
Compare
Currently we have one event that is sent if a mission run is updated in any way. Since this means that an update to a step also implies an update due to a task update, we could potentially create more fine tuned events to avoid unnecessary events in the frontend. So if you are only interested in the status of a mission changing then you could subscribe just to that and ignore step and task updates, for example. |
b7151b6
to
0dfa8a4
Compare
All frontend polling has been removed except the call to get mission runs within the history page filter. This one could be removed by having the GET request only be made when a "mission run updated/created" event is received which would not be filtered away, but since "mission run updated" is called each time a task is completed, this may create be a small improvement overall, for the price of more complicated code. It may still be worthwhile doing at some point though, especially as it would be satisfying to remove the last reference to "refreshInterval". |
111266f
to
0637251
Compare
33c3d32
to
6fafb3d
Compare
6fafb3d
to
a9e50b4
Compare
🔔 Migrations changes detected 🔔 |
2edd1bb
to
9478ca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
27b7f1b
to
cd05c96
Compare
cd05c96
to
c9204d5
Compare
/UpdateDatabase |
👀 Running migration command... 👀 |
✨ Successfully ran migration command! ✨ |
Closes #1020 #1063
This PR connects the frontend and backend to SignalR, and then replaces polling for missionRuns and failed missions for the mission queue and failed missions banner.
It is important to note that in order to use signalR in a react context, that context provider must be nested within the signalR provider in flotillasite.tsx