Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore erroneous auto-scale configuration, but warn #9390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

berland
Copy link
Contributor

@berland berland commented Nov 28, 2024

Issue
Resolves #9339

Approach
Detect and ignore (but warn)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Nov 28, 2024
@@ -6,9 +6,11 @@ RUNPATH poly_out/realization-<IENS>/iter-<ITER>
OBS_CONFIG observations
REALIZATION_MEMORY 50mb

NUM_REALIZATIONS 100
NUM_REALIZATIONS 10
Copy link
Contributor

@eivindjahren eivindjahren Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we should change anything in the test-data. Maybe we could instead just edit this in the test.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently edits the test-data in place, this should instead just be handled in the test to avoid coupling tests together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERT fails in update step if AUTO_SCALE cannot match any observations
2 participants