New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tests run in clean directory #9379

Merged

berland merged 1 commit into equinor:main from berland:fix_flaky_uppercasing

Nov 28, 2024

Contributor

berland commented Nov 28, 2024 •

edited

Loading

Not doing this causes tests to step on each others toes, yielding flakyness

Issue
Resolves #9377

Approach
🧠

Flakyness reproducable with --count 1000 -n 8. Not reproducible with this fix.

PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

When there are user facing changes: Updated documentation
New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
Large PR: Prepare changes in small commits for more convenient review
Bug fix: Add regression test for the bug
Bug fix: Create Backport PR to latest release


          Ensure tests run in clean directory

ed11edd

Not doing this causes tests to step on each others toes, yielding
flakyness

berland added the release-notes:skip label

berland enabled auto-merge (rebase)

November 28, 2024 10:48

eivindjahren approved these changes

View reviewed changes

berland merged commit af36009 into equinor:main

40 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:skip