Simplify LibresFacade by removing duplicated functionality #9376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindeide
force-pushed
the
fix_run_path_duplication
branch
from
59bb30c
to
b684887
Compare
oyvindeide
added
the
release-notes:maintenance
Also cleans up libres facade functionality for reading from runpath
oyvindeide
force-pushed
the
fix_run_path_duplication
branch
from
b684887
to
afad192
Compare
DanSava
approved these changes
Nov 29, 2024
| @@ -122,10 +122,10 @@ def from_config_dict(cls, config_dict: ConfigDict) -> Optional[Self]: | |||
| def read_from_file(self, run_path: str, iens: int, iter: int) -> polars.DataFrame: | |||
| def _read_file(filename: Path, report_step: int) -> polars.DataFrame: | |||
| try: | |||
| data = np.loadtxt(_run_path / filename, ndmin=1) | |||
| data = np.loadtxt(filename, ndmin=1) | |||
There was a problem hiding this comment.
❤️ I also stumbled on this while working on something unrelated, and forgot to follow up with more investigation on why it was so strange. I am glad to see it fixed.
There was a problem hiding this comment.
Yes, it works because adding two abs path together ignores the shared parents, I did not know that, and once I started using _run_path as a relative path in the tests, it stopped working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning some code only used in tests
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable