Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Flask with FastAPI #9243

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Nov 18, 2024

Issue
Resolves #9201

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad self-assigned this Nov 18, 2024
@frode-aarstad frode-aarstad marked this pull request as draft November 18, 2024 13:20
@frode-aarstad frode-aarstad marked this pull request as ready for review November 20, 2024 11:44
@frode-aarstad frode-aarstad added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 20, 2024
@frode-aarstad frode-aarstad force-pushed the switch-to-fastapi branch 3 times, most recently from 6bd86ae to 128f7e7 Compare November 20, 2024 13:27
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean. 👍

@frode-aarstad frode-aarstad merged commit adda9e0 into equinor:main Nov 21, 2024
42 checks passed
@frode-aarstad frode-aarstad deleted the switch-to-fastapi branch November 21, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use FastAPI instead of Flask for detatched server
2 participants