Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test field with FORWARD_INIT:False #9202

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Test field with FORWARD_INIT:False #9202

merged 2 commits into from
Nov 21, 2024

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Nov 13, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Nov 13, 2024
@dafeda dafeda self-assigned this Nov 13, 2024
@dafeda dafeda force-pushed the forward-init-false branch 2 times, most recently from a73f20a to e9ce463 Compare November 18, 2024 08:36
xjules
xjules reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR @dafeda ! Just had smaller comments.

xjules
xjules approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just squash the two commits and 🚀

@dafeda dafeda merged commit 33cc2c2 into equinor:main Nov 21, 2024
42 checks passed
@dafeda dafeda deleted the forward-init-false branch November 21, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjules xjules xjules approved these changes

Assignees

@dafeda dafeda

Labels
release-notes:skip If there should be no mention of this in release notes
Projects
SCOUT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafeda @xjules