Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate future code sharing alternatives #2695

Open
BorghildSelle opened this issue Nov 26, 2024 · 0 comments
Open

Investigate future code sharing alternatives #2695

BorghildSelle opened this issue Nov 26, 2024 · 0 comments

Comments

@BorghildSelle
Copy link
Contributor

BorghildSelle commented Nov 26, 2024

In the news future new projects might want to use energy vision components but should be separate repos. They may want to cherry-pick the components so need to look at offering npm packages for Equinor tailwind config, energy vision core react components, sections sanity page content blocks, sanity web page templates.

Discuss:

  • Should those packages reside in energyvision repo together with equinor.com? The new projects might have their own components which should also be shared within more than themselves, which is not relevant for equinor.com. Having the packages within the monorepo of equinor.com simplifies the development of the packages when changes for equinor.com is implemented. But not for the other projects.

  • Or should all energyvision packages be a separate mono for "cleaner" setup and in thread with separation of concerns principal? Visual test might be written in this new repos for the different "consumers" with puppeteer/Percy/Playwright/storybook/chromatic or some other visual testing/ unit testing setups. This might also make it more clear when writing up schema requirements or schema dependencies in Sanity needed for the sections or templates packages

  • The libraries should make it possible to install the individual components within the library e.g. @equinor/energyvision-sections/textblock

  • The different projects will require its own web application and custom setup of Sanity where they will pull from the packages what they need. All projects will most probably pull the tailwind config package and core react components to setup web applications with. But then cherrypick for sections and web page templates.

  • Could sanity page templates schemas be packaged ? to reuse schemas?

  • Could sanity objects be packaged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant