Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metal] pagination does not pass context into the looped API calls #12

Open
displague opened this issue Dec 20, 2023 · 2 comments
Open

Comments

@displague
Copy link
Member

This could prevent cancelation

@ctreatma
Copy link
Contributor

Can you provide links to the code that should be passing context but isn't? Do you have a code example that demonstrates the loss of context?

@ctreatma
Copy link
Contributor

ctreatma commented Feb 7, 2024

In general, request objects have a ctx property that tracks the specified context; the auto-pagination works by updating the page parameter of the request and then executing the request, so I would expect the context to be held across all requests.

For example, here's the definition of the ApiFindProjectsRequest, and here's the ExecuteWithPagination method of that request.

@ctreatma ctreatma changed the title Metal pagination does not pass context into the looped API calls [Metal] pagination does not pass context into the looped API calls Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants