Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(deps) Update init-tracing-opentelemetry #4

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

nshalman
Copy link
Contributor

This commit brings in init-tracing-openetelemtry 0.24.1 which fixes a bug where spans might not get sent before program termination.

Updating to this version may require some light code changes to ensure that the guard struct is being
handled correctly to ensure trace flushing.

Fixes #3

Related:

This commit brings in init-tracing-openetelemtry 0.24.1
which fixes a bug where spans might not get sent before
program termination.

Updating to this version may require some light code
changes to ensure that the guard struct is being
handled correctly to ensure trace flushing.

Fixes equinix-labs#3

Related:
- davidB/tracing-opentelemetry-instrumentation-sdk#184
- davidB/tracing-opentelemetry-instrumentation-sdk#185
@nshalman nshalman marked this pull request as ready for review November 25, 2024 17:18
@nshalman
Copy link
Contributor Author

I have tested this and confirmed that it appears to resolve the issue for me.

@ScottGarman ScottGarman merged commit 83d653d into equinix-labs:main Nov 25, 2024
@nshalman nshalman deleted the fix-trace-flushing branch November 26, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking upstream bug
2 participants