Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render of mêlée is not ideal with GuiRenderLigature 1 #872

Closed
kierun opened this issue Jul 2, 2021 · 3 comments
Closed

Render of mêlée is not ideal with GuiRenderLigature 1 #872

kierun opened this issue Jul 2, 2021 · 3 comments

Comments

@kierun
Copy link

kierun commented Jul 2, 2021

Using nvim-qt, I get this:

screenshot

Using the console nvim, I get this:

screenshot-console

Note that the font is the same in both instances so it should render fine.

Setting GuiRenderLigature 0 instead of 1 makes the problem vanish.

NVIM-QT v0.2.17.9999
Build type:
Compilation: -Wall -Wextra -Wno-unused-parameter -Wunused-variable -std=c++11
Qt Version: 5.15.2
Environment:
  nvim: nvim
  args: --cmd let &rtp.=',/home/yann/bin/../share/nvim-qt/runtime' --cmd set termguicolors
  runtime: /home/yann/bin/../share/nvim-qt/runtime

NVIM v0.5.0-dev+1455-gf83c25942
Build type: Debug
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=1 -I/home/yann/src/neovim/build/config -I/home/yann/src/neovim/src -I/home/yann/src/neovim/.deps/usr/include -I/usr/include -I/home/yann/src/neovim/build/src/nvim/auto -I/home/yann/src/neovim/build/include
Compiled by [email protected]

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/home/yann/nvim/share/nvim"

Run :checkhealth for more info
@jgehrig
Copy link
Collaborator

jgehrig commented Jul 6, 2021

I cannot reproduce this issue.

What platform? (MacOS or Linux)
What font?
Does this issue appear for all fonts?

This looks like another rendering scenario that may be fixed by #781.

Sorry, I've procrastinated on that change... I don't like the code.

That PR essentially adds yet-another rendering code path. Ligatures are tricky!

@kierun
Copy link
Author

kierun commented Jul 6, 2021

What platform? (MacOS or Linux)

Fedora 34. 5.12.13-300.fc34.x86_64 #1 SMP Wed Jun 23 16:18:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

What font?

Pragmata Pro

Does this issue appear for all fonts?

Of course not… Stupid font I use… It works fine on Monoid Nerd Font.

Yeah, we can close this. Apologies for the noise.

@kierun kierun closed this as completed Jul 6, 2021
@jgehrig
Copy link
Collaborator

jgehrig commented Jul 6, 2021

No worries!

Sorry for the delays with PR 781... I need to finish that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants