You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Perhaps we could use the WP class for parsing the DOM instead of including simple_html_dom.php (which has non-namespaced functions and is thus a pretty big risk)? The WP_HTML_Tag_Processor class was introduced in 6.2.
The text was updated successfully, but these errors were encountered:
This is interesting for PHP-based scans. I'll do some more research on it. PHP's built-in DOM parser DOMDocument is another choice. In hindsight, I would have chosen DOMDocument over Simple HTML DOM. But I also like the idea of a WordPress way of parsing.
We're working towards scanning the full rendered page with JavaScript instead of PHP. This allows us to utilize the axe-core library and reduces false positives. We've set the plugin up to allow for both PHP and JS scans so we can migrate checks over time. There is a beta release with JS scanning implemented on the color contrast check.
Once all checks are converted to JavaScript we can remove Simple HTML DOM entirely.
Perhaps we could use the WP class for parsing the DOM instead of including
simple_html_dom.php
(which has non-namespaced functions and is thus a pretty big risk)? TheWP_HTML_Tag_Processor
class was introduced in 6.2.The text was updated successfully, but these errors were encountered: