Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sandpaper cache, update digest #31

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Update sandpaper cache, update digest #31

merged 2 commits into from
Oct 23, 2023

Conversation

pratikunterwegs
Copy link
Contributor

@pratikunterwegs pratikunterwegs commented Oct 17, 2023

This is a draft PR to fix #30 - I don't seem to be able to make drafts. Changes in this PR come from running sandpaper::update_cache(), which updates {digest} from v0.6.32 to v0.6.33; {htmltools} seems to be the direct dependency which imports {digest}.

This PR also updates {renv} required to v1.0.3 in line with the workbench template.

However please be aware that {epidemics} is also being updated, which may have implications for the lesson on late tasks.

The following package(s) will be installed:
- epidemics  [epiverse-trace/epidemics@HEAD]
- fansi      [1.0.5]
- foreign    [0.8-85]
- ggplot2    [3.4.4]
- htmltools  [0.5.6.1]
- KernSmooth [2.23-22]
- lattice    [0.21-9]
- Matrix     [1.6-1.1]
- mgcv       [1.9-0]
- nlme       [3.1-163]
- rpart      [4.1.21]
- spatial    [7.3-17]
- survival   [3.5-7]
- tinytex    [0.48]
- vctrs      [0.6.4]

Finally, the version of R is also being updated:

The version of R recorded in the lockfile will be updated:
- R             [4.3.0 -> 4.3.1]

@github-actions
Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files or spoofing.

It should be safe to Approve and Run the workflows that need maintainer approval.

@pratikunterwegs pratikunterwegs requested review from amanda-minter and avallecam and removed request for amanda-minter and avallecam October 17, 2023 11:05
@Bisaloo
Copy link
Member

Bisaloo commented Oct 17, 2023

Thanks! Could you also update to renv >=1.0.0 in the same PR please? It will require rebuilding the cache so best to do it just once.

@pratikunterwegs
Copy link
Contributor Author

pratikunterwegs commented Oct 17, 2023

Thanks! Could you also update to renv >=1.0.0 in the same PR please? It will require rebuilding the cache so best to do it just once.

Is there a {sandpaper}-specific way of doing this or is it a normal {renv} update? The links between the two make it a bit confusing.

@amanda-minter amanda-minter requested review from avallecam and removed request for amanda-minter October 17, 2023 12:18
@avallecam
Copy link
Member

avallecam commented Oct 20, 2023

Thank you for catching up on this issue and providing a solution.

This change updates files directly from a carpentries update, plus the renv update, so this looks fine and ready to merge.

I'll share a proposal of steps to follow for package versions in a separate issue.

@avallecam
Copy link
Member

These changes will go to the main branch but will not affect development branches. I assume that to make these changes useful for the reviews, this requires a new PR from main to the late_task_1 branch after merging this, and then request @amanda-minter to pull it to keep building over it.

@pratikunterwegs, can you confirm this? I can make that next step.

@pratikunterwegs
Copy link
Contributor Author

Thanks @avallecam - to bring the branches up to date with main you could rebase and force push them; no need for a PR. See more in this primer with a diagram from GitLab. Happy to help with this if needed.

@pratikunterwegs pratikunterwegs merged commit 4d96dd7 into main Oct 23, 2023
3 checks passed
@pratikunterwegs pratikunterwegs deleted the dev/fix-renv branch October 23, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message when using sandpaper due to digest
3 participants