-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install sandpaper from our fork #101
Conversation
So we can keep it in sync and keep other workbench pkgs up to date as well
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials/compare/md-outputs..md-outputs-PR-101 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-12-21 11:51:36 +0000 |
The two issues are independent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bisaloo , thank you for this PR.
My understanding is that:
- now we have the two features (patch and es-translations) in one branch https://github.com/epiverse-trace/sandpaper/tree/patch-renv-github-bug
- also, the Spanish translations were already added in the corresponding
R-es.po
file https://github.com/epiverse-trace/sandpaper/blob/patch-renv-github-bug/po/R-es.po
This implies that:
- the maintenance role should (1) keep the epiverse-main fork in sync with the carpentries-main branch, (2) rebase the
patch-renv-github-bug
feature branch to keep everything up to date. - we do not need to complete the ES translations as added by the commit cited in this issue translate to ES more strings in
sandpaper
epimodelac#19 - thus, we also need to replicate this update in this line https://github.com/epiverse-trace/epimodelac/blob/09d420c6001b6c8a6b506630a809db910b0c26f6/config.yaml#L86
This seems to knit well in the git-novice Spanish translation too.
Let me know if I'm missing sth. If not, then, I'll close the cited issues and open some PRs in the required repos.
I can do this since there are a couple of tricky git operations to ensure we keep clean branches with our patches but benefit from the latest workbench features.
Not yet because I need to sync varnish for this first to get spanish translations with epiverse theme. But I can't do this until tutorials is rendered with the latest sandpaper version because of the issue mentioned in the first comment. This is a good illustration of the complexity of interdependencies between packages I mentioned in meetings about Epiverse-TRACE scaffolding and architecture. |
Thank you for taking the lead on this. Could you register these tricky git operations somewhere? Possibly not now, but we can find some moment to share what steps you followed, or if this scenarios happens again, how to deal with it.
So, if this means to merge this PR to sync with {varnish}, feel free to merge it as you wish 🚀
Should this go also to the bucked list of topics for the blog post idea about our experience with the workbench infraestructure? |
Possibly, it could be under a section "if you want to use a custom fork of a given workbench repo, you'll likely need to maintain forks of the others" |
Auto-generated via {sandpaper} Source : 5dcca7c Branch : main Author : Andree Valle Campos <[email protected]> Time : 2024-02-06 16:02:33 +0000 Message : replace draft PR with updated branch following epiverse-trace/tutorials#101
Auto-generated via {sandpaper} Source : 888c82a Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-06 16:05:17 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 5dcca7c Branch : main Author : Andree Valle Campos <[email protected]> Time : 2024-02-06 16:02:33 +0000 Message : replace draft PR with updated branch following epiverse-trace/tutorials#101
Auto-generated via {sandpaper} Source : 888c82a Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-06 16:05:17 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 5dcca7c Branch : main Author : Andree Valle Campos <[email protected]> Time : 2024-02-06 16:02:33 +0000 Message : replace draft PR with updated branch following epiverse-trace/tutorials#101
Auto-generated via {sandpaper} Source : 5dcca7c Branch : main Author : Andree Valle Campos <[email protected]> Time : 2024-02-06 16:02:33 +0000 Message : replace draft PR with updated branch following epiverse-trace/tutorials#101
Auto-generated via {sandpaper} Source : 7604048 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-20 00:32:16 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 5dcca7c Branch : main Author : Andree Valle Campos <[email protected]> Time : 2024-02-06 16:02:33 +0000 Message : replace draft PR with updated branch following epiverse-trace/tutorials#101
This is needed because
carpentries/sandpaper@main
contains the translation feature which is absent from the patch branch.If we keep installing from the outdated patch branch and try to use the latest varnish version, this will result in missing text.