Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 123 #130

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Fix issue 123 #130

merged 5 commits into from
Oct 1, 2024

Conversation

Degoot-AM
Copy link
Contributor

@Degoot-AM Degoot-AM commented Sep 23, 2024

This PR addresses issue #123.

Fix #123
Fix #104

Copy link

github-actions bot commented Sep 23, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-early/compare/md-outputs..md-outputs-PR-130

The following changes were observed in the rendered markdown documents:

 describe-cases.md                                  | 488 ++++++++++-----------
 ...ibe-cases-rendered-unnamed-chunk-10-1.png (new) | Bin 0 -> 6655 bytes
 ...be-cases-rendered-unnamed-chunk-11-1.png (gone) | Bin 13312 -> 0 bytes
 fig/describe-cases-rendered-unnamed-chunk-12-1.png | Bin 7643 -> 27793 bytes
 ...ibe-cases-rendered-unnamed-chunk-13-1.png (new) | Bin 0 -> 23159 bytes
 fig/describe-cases-rendered-unnamed-chunk-7-1.png  | Bin 5791 -> 6821 bytes
 fig/describe-cases-rendered-unnamed-chunk-8-1.png  | Bin 9477 -> 8971 bytes
 fig/describe-cases-rendered-unnamed-chunk-9-1.png  | Bin 6284 -> 8236 bytes
 md5sum.txt                                         |   4 +-
 9 files changed, 245 insertions(+), 247 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-01 02:10:07 +0000

github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
@Degoot-AM Degoot-AM requested a review from avallecam September 23, 2024 19:17
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits and working in to this! I'll do the merge 🚀

@avallecam avallecam merged commit ac9b22e into main Oct 1, 2024
6 checks passed
@avallecam avallecam deleted the fix_issue_123 branch October 1, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants