Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix review and user testing items #205

Merged
merged 236 commits into from
Sep 23, 2024
Merged

Fix review and user testing items #205

merged 236 commits into from
Sep 23, 2024

Conversation

GeraldineGomez
Copy link
Member

No description provided.

Bisaloo and others added 30 commits July 18, 2024 16:41
@Bisaloo
Simplify and fix concatenar_vals_token()
28d32d4 
Since until now, the loop continued beyond longitud if the string was longer
@Bisaloo
Replace use of superseded _at() dplyr functions
ce1b0f7
@Bisaloo
Remove duplicate ggplot theme specification
0e6a5c2
@Bisaloo
Simplify nested paste0() calls
bc13e03
@Bisaloo
Make arg defaults explicit
11a8a0f
@Bisaloo
Use c() instead of append()
901dfc0
@Bisaloo
Make code responsive to events_adicionales length
691cb4d
@Bisaloo
Make sure input checking happens early enough
8703b4f
@Bisaloo
Add comment to explicit the necessary of 'tam' arg
d331b62
@Bisaloo
Use geom_col() rather than geom_bar()
a028071
@Bisaloo
Rely on data.frame recycling of scalar where appropriate
596fd91
@Bisaloo
Avoid reusing var name for two different object types
95418ae
@Bisaloo
Read RDS files rather than RDA files
ab2201c
@Bisaloo
Remove unnecessary parse(eval()) calls
5d423d4
@Bisaloo
Remove input checking in internal functions
6d3dd4c 
As discussed with Geraldine
@Bisaloo
Simplify obtener_fila_mas_casos()
34894f1
@Bisaloo
Remove always TRUE condition
9c2242e
@Bisaloo
Use orientation = "y" instead of coord_flip()
0ad6c54
@Bisaloo
Remove unneeded special handling of edge cases
a5d321a
@Bisaloo
Remove unnecessary initializations
b9d3d93
@Bisaloo
Simplify special casing of Malaria
e1b3a86
@Bisaloo
Remove non-existing argument in toString()
b14914b
@Bisaloo
Ensure connection is always closed
72ba167
@Bisaloo
Exit early on edge case
86b927b
@Bisaloo
Avoid growing vectors in loops
c55e306
@Bisaloo
Copy infrastructure files from packagetemplate
892f834
@actions-user @Bisaloo
Automatic readme update
4b325bb
@Bisaloo
Copy infrastructure files from packagetemplate
6a2eee8
@Bisaloo
Fix some typos
4d6218d
@Bisaloo
Run styler::style_pkg()
0201c37
GeraldineGomez and others added 27 commits August 14, 2024 12:29
@GeraldineGomez
chore: added windows folder for dicitiontaries
f463377 
Ref: #194
@GeraldineGomez
chore: restore spelling file
cd6b7a6 
Ref: #194
@gsgomezm
fix: validate Malaria Asociada parenthesis pattern
f557702
@gsgomezm
fix: age range and validation
a968a2f
@gsgomezm
chore: parametrization of code_eve reference
60a93f2
@gsgomezm
chore(incidence): add cache parameter in functions to improve the per…
690caee 
…fomance
@gsgomezm
fix(agrupar_edad_sex): age validation
f40c1ac
@GeraldineGomez
fix(import_data_event): add fec_def validation
cbbe783
@GeraldineGomez
fix(plotting): automatization of plot scale based on column reference
2ad86ef
@GeraldineGomez
chore: standardization of cod_eve reference
dd1dd81
@GeraldineGomez
fix(limpiar_data_sivigila): age validations
4186c0b
@GeraldineGomez
chore: update README file
d5d21b8
@GeraldineGomez
chore(skeleton): add cache parameter reference in incidence function
aa7db16 
Ref: #194
@GeraldineGomez
chore(skeleton): standardization of nombre_evento and cod_eve column
b4b77ae
@GeraldineGomez
chore: update documentation
d67803e
@GeraldineGomez
fix(estandarizar_geo_cods): add validation of geo columns
ade3e5b
@GeraldineGomez
chore(convert_edad): add others uni_med to convert the age
7ab39d1
@GeraldineGomez
chore: remove spelling validation
aa55d24
@GeraldineGomez
chore: remove spelling
8ed0bfd
@GeraldineGomez
fix: lintr space and lines
e8cf594
@GeraldineGomez
chore: update the request timeout of SIVIGILA
318fa88
@GeraldineGomez
chore(resources): add link to data dictionary from SIVIGILA
095b537 
Ref: #194
@GeraldineGomez
chore(style): reduce width of title in css file
1348687 
Ref: #194
@GeraldineGomez
chore: update incidencia_eventos dataset
354c9bd 
Ref: #194
@GeraldineGomez
chore(skeleton): improve size of figures for HTML format
8434bb6 
Ref: #194
@GeraldineGomez
Merge remote-tracking branch 'origin/main' into fix-review-items
85bf823
@GeraldineGomez
fix: remove lintr space
12ebeea 
Ref: #194
@GeraldineGomez GeraldineGomez merged commit 12ebeea into main Sep 23, 2024
8 checks passed
@GeraldineGomez GeraldineGomez deleted the fix-review-items branch September 23, 2024 20:42
@GeraldineGomez GeraldineGomez restored the fix-review-items branch September 23, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeraldineGomez @Bisaloo @actions-user @gsgomezm