Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dependency on R 4.1 #266

Open
Bisaloo opened this issue Dec 9, 2024 · 1 comment · May be fixed by #268
Open

Document dependency on R 4.1 #266

Bisaloo opened this issue Dec 9, 2024 · 1 comment · May be fixed by #268

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Dec 9, 2024

#249 introduced the use of the base pipe |>, which is only available since R 4.1.

This means that serofoi now depends on R >= 4.1.0.

Note that this means that serofoi is not completely aligned with Epiverse & the tidyverse's standards in terms of R version support. This is not a big deal but it might mean that some users will be forced to upgrade their R version to use serofoi.

I think it can stay this way for simplicity and because the new version of R should be release in < 6 months and make serofoi compliant with our policy again.

However, the dependency definitely needs to be documented as serofoi currently reports it is compatible to versions as old as R 3.5.0:

serofoi/DESCRIPTION

Lines 21 to 22 in 4be70e3

Depends:
R (>= 3.5.0)

Adding the oldest supported version to the CI matrix can also be a good way to make sure the declared oldest supported version is indeed compatible with the package:

matrix:
config:
- {os: macOS-latest, r: 'release'}
- {os: windows-latest, r: 'release'}
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel-1'}

Please let me know if you'd like a PR for this. And if so, please let me know which branch should be targeted.

@ntorresd
Copy link
Member

Hi @Bisaloo, thanks for pointing this out. You can target main now.

@ntorresd ntorresd reopened this Dec 10, 2024
@Bisaloo Bisaloo linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants