Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use labels instead of variable names in validate_types() #57

Open
Bisaloo opened this issue Dec 10, 2024 · 0 comments
Open

Use labels instead of variable names in validate_types() #57

Bisaloo opened this issue Dec 10, 2024 · 0 comments

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Dec 10, 2024

The idea behind safeframe in my opinion is that you only need to change the first line of your script, the make_safeframe() call when you change your data source and the new one uses new column names.

This means that all other functions should use the labels rather than the variable names.

In particular, I would expect validate_types() to do so.

In linelist for example, we know what type we expect to each tag/label but we don't know to which column this tag/label will be attached. The only way we can provide expected types to default tags is by using tags in validate_types() rather than variable names.

@Bisaloo Bisaloo added this to the Before first CRAN release milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant