Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt content to outbreak context and R packages #13

Merged
merged 153 commits into from
Nov 27, 2023
Merged

Conversation

avallecam
Copy link
Member

@avallecam avallecam commented Nov 7, 2023

  • Please check if the PR fulfils these requirements
  • I have read the CONTRIBUTING guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What breaking change does this PR introduce?

    • The approach now is to adapt our topic/approach to the git-novice with minimum replacements, instead of adapting the git-training slides to a workbench format.
    • Benefits from this: use as much as possible plain-text commands, either in the console or in the terminal. This keeps the material accessible, given that it reduces the need for screenshots with actions in graphical window interfaces.
  • For Reviewers:

github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
Co-authored-by: Joshua Lambert <[email protected]>
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
episodes/03-create.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
@avallecam
Copy link
Member Author

avallecam commented Nov 23, 2023

Thank you for the review!

I covered your edit suggestions in the recent commits.

I created new issues covering comments in this PR:

Given the scope of this PR, I think I can solve them in separate PRs, prioritizing #24 and #17. Let me know if you agree with this.

episodes/06-ignore.md Outdated Show resolved Hide resolved
@joshwlambert
Copy link
Member

@avallecam Really nice work on the tutorial!

I've added all of my comments within the PR to specific lines.

The only other comment I had was I think that more information on branching and merging using Git is required for a beginner. The collaboration workflow is heavily dependent on Git users being able to branch and make changes in parallel to collaborators. A lot of this information is already included in 14-supplemental-rstudio.html#create-a-branch but I think this should be moved into a standalone chapter with some more information. If you decide to do this it can be done in a separate PR like the issues you raised in the comment above.

@avallecam
Copy link
Member Author

The only other comment I had was I think that more information on branching and merging using Git is required for a beginner. The collaboration workflow is heavily dependent on Git users being able to branch and make changes in parallel to collaborators. A lot of this information is already included in 14-supplemental-rstudio.html#create-a-branch but I think this should be moved into a standalone chapter with some more information. If you decide to do this it can be done in a separate PR like the issues you raised in the comment above.

I agree with your comment. I'll cite this in a new issue for a standalone chapter

github-actions bot pushed a commit that referenced this pull request Nov 27, 2023
github-actions bot pushed a commit that referenced this pull request Nov 27, 2023
@avallecam avallecam merged commit 7b8e41d into main Nov 27, 2023
3 checks passed
@avallecam avallecam deleted the dev-adapt-v2 branch November 27, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a outbreak related scenario
2 participants