Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do if parameterised distributions are not on {epiparameter}? #114

Closed
CarmenTamayo opened this issue Dec 11, 2023 · 4 comments
Closed

Comments

@CarmenTamayo
Copy link
Contributor

At the moment the transmissibility report offers 2 options:

a) A distribution is extracted from the epiparameter database directly and parameters are used for the SI (On PR #100 this is limited to parameterised distributions using "subset = is_parameterised")
b) The user provides the mean and sd of their data and the template includes the conversion to distribution parameters (and since PR #100 an epidist object is created where the conversion happens automatically, as discussed on issue #112 )

There's a potential 3rd option where the distribution obtained from the epiparameter database isn't parameterised- in this case, the template doesn't currently include an option to convert/extract the parameters

For now, we've agreed to assume that a user will either provide the mean and sd of their data and therefore convert them, or that they will want to use the epiparameter database directly, to avoid adding more parameters to the params list (see issue #106 )

This is unless there was a way to automatically convert the summary statistics reported on database studies when extracting them using epidist_db, similarly to the auto_calc_parameters argument on epidist ? If there is a way I haven't managed to do so @joshwlambert

@joshwlambert
Copy link
Member

All studies in the {epiparameter} database that have summary statistics that can be converted (or extracted) into distribution parameters should be considered "parameterised" and have distribution parameters. This is because the data coming from epidist_db() is created using epidist(). Please provide a reprex to show where this is not the case as it may be a bug.

@CarmenTamayo
Copy link
Contributor Author

So for studies that provide summary statistics, the conversion/extraction is done automatically and included in the database?

@joshwlambert
Copy link
Member

So for studies that provide summary statistics, the conversion/extraction is done automatically and included in the database?

Yes.

@CarmenTamayo
Copy link
Contributor Author

CarmenTamayo commented Dec 12, 2023

So for studies that provide summary statistics, the conversion/extraction is done automatically and included in the database?

Yes.

Okay that's great, so to avoid extracting a study that is not parameterised, because the reported summary statistics weren't enough to do so, but it may be the only study available for a certain disease and parameter type, I've changed the code on the transmissibility template to include subset = is_parameterised when using epidist_db, and studies that aren't won't be used in the templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants