Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mocking for get_survey() tests #52

Open
Bisaloo opened this issue Sep 5, 2022 · 1 comment
Open

Use mocking for get_survey() tests #52

Bisaloo opened this issue Sep 5, 2022 · 1 comment

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Sep 5, 2022

Currently, get_survey() tests are skipped on CRAN and on CI, which means they might rarely run and issues could easily go unseen.

skip_if_no_zenodo()
skip_on_cran()
skip_on_ci()

Instead, we should add mocking to run these tests to make sure we don't break get_survey(). Mocked resources should still be regularly updated to detect possible changes on zenodo's end.

Useful resource: https://books.ropensci.org/http-testing/

@Bisaloo
Copy link
Member Author

Bisaloo commented Sep 5, 2022

Might be related to #51 depending on the approach we take there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants