This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
Add account sheet #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakajima
approved these changes
Feb 1, 2023
| guard let url = URL(string: privacyUrl) else { | ||
| return | ||
| } | ||
| UIImpactFeedbackGenerator(style: .heavy).impactOccurred() |
There was a problem hiding this comment.
Could be nice to maybe extract a HapticButton component since we're doing this in a few places? Maybe something like:
struct HapticButton<Content: View>: View {
var action: () -> Void
@ViewBuilder var label: () -> Content
var body: some View {
Button(action: {
UIImpactFeedbackGenerator(style: .heavy).impactOccurred()
action()
}) {
label()
}
}
}Lemme know if you think that's overkill.
There was a problem hiding this comment.
Added and migrated most views over to it! Brilliant idea.
xmtp-inbox-ios/Views/HomeView.swift
Outdated
| EnsImageView(imageSize: 40.0, peerAddress: client.address) | ||
| }) | ||
| .navigationBarItems(leading: EnsImageView(imageSize: 40.0, peerAddress: client.address) | ||
| .onTapGesture { |
There was a problem hiding this comment.
Could this be a button instead of an onTapGesture? I think it'll work better with VoiceOver in that case.
There was a problem hiding this comment.
Ended up using the new HapticButton 😁
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our "Account" view to a sheet and updates the designs to closer match Figma. I made the privacy URL link to
https://xmtp.org/privacyand the support url link tohttps://github.com/xmtp-labs/xmtp-inbox-ios/issues.I also migrated our fetch/stream messages logic into the
MessageListViewto match how we are fetching/streaming in theConversationListView, but I can revert if you're not a fan!Relates to #13