Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Bug: WalletConnect flow doesn't choose between apps #41

Open
Tracked by #3
elisealix22 opened this issue Feb 2, 2023 · 9 comments
Open
Tracked by #3

Bug: WalletConnect flow doesn't choose between apps #41

elisealix22 opened this issue Feb 2, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@elisealix22
Copy link
Contributor

If I have Rainbow, Ledger & MetaMask installed on my device, Rainbow opens the wc URL even though I want to use a different wallet app and there's no way to change between them currently.

@elisealix22 elisealix22 added the bug Something isn't working label Feb 2, 2023
@elisealix22 elisealix22 self-assigned this Feb 2, 2023
@elisealix22
Copy link
Contributor Author

I'm going to explore setting up WC v2 first and will report back if that changes anything!

@nakajima nakajima self-assigned this Feb 8, 2023
@nakajima
Copy link
Contributor

nakajima commented Feb 8, 2023

I gave WC v2 a try in #47 but I think we'll need to wait on this until MetaMask supports it.

Do we have an idea on how we'd like this to behave? Should we show our own screen offering popular wallet apps and try to allow people to select one of them explicitly instead of relying on whichever wc:// handler iOS gives us first?

@elisealix22
Copy link
Contributor Author

@nakajima that's exactly what I was thinking. I think we'll want to create our own modal that allows people to choose between a subset of wallets & then maybe have a fallback WC button as well that uses the wc:// url. Not perfect, but should offer a little more control than what we have today!

@m-005
Copy link

m-005 commented Feb 9, 2023

I'm down for a custom modal.

Two worries that aren't blockers:

  • We'll have to maintain the modal long term
  • A custom modal would create UI/UX difference between web and native mobile

@nakajima
Copy link
Contributor

nakajima commented Feb 9, 2023

cc @darickdang for UI

@darickdang
Copy link

Sounds good!

@nakajima
Copy link
Contributor

Update here: Now that we're using RainbowKit, you can choose between apps. Sometimes those apps don't open though…

@nakajima
Copy link
Contributor

OK, I think we might want our own custom modal here, things just haven't been consistent enough using the webview.

@m-005
Copy link

m-005 commented Mar 2, 2023

Relates to #3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants