From b7b9dd080901523becd4a7a8e122422d4aa75634 Mon Sep 17 00:00:00 2001
From: ponsfrilus <ponsfrilus@gmail.com>
Date: Fri, 17 Mar 2017 14:48:55 +0100
Subject: [PATCH] Better CSS and linter compliant

---
 build/webpack.base.conf.js            | 10 ++++++++++
 src/App.vue                           |  3 ---
 src/components/EPFLTopics.vue         |  7 ++++---
 src/components/partials/Avatar.vue    |  4 ++--
 src/components/partials/EPFLTopic.vue |  5 +++--
 5 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/build/webpack.base.conf.js b/build/webpack.base.conf.js
index f8e77ce6..c8237193 100644
--- a/build/webpack.base.conf.js
+++ b/build/webpack.base.conf.js
@@ -35,6 +35,16 @@ module.exports = {
   },
   module: {
     rules: [
+      { // eslint
+        enforce: 'pre',
+        test: /\.(vue|js)$/,
+        loader: 'eslint-loader',
+        include: projectRoot,
+        exclude: /node_modules/,
+        options: {
+          formatter: require('eslint-friendly-formatter')
+        }
+      },
       {
         test: /\.js$/,
         loader: 'babel-loader',
diff --git a/src/App.vue b/src/App.vue
index f1d7746e..5bc137f3 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -40,9 +40,6 @@
  * Root component
  */
   export default {}
-
-var foo = "bar" + 'baz';
-
 </script>
 
 <style>
diff --git a/src/components/EPFLTopics.vue b/src/components/EPFLTopics.vue
index c3c4ac78..f448cd3d 100644
--- a/src/components/EPFLTopics.vue
+++ b/src/components/EPFLTopics.vue
@@ -11,7 +11,7 @@
 <script>
 import EPFLTopic from './partials/EPFLTopic'
 export default {
-  components: {"epfl-topic": EPFLTopic},
+  components: {'epfl-topic': EPFLTopic},
   data () {
     return {
       topics: []
@@ -21,9 +21,10 @@ export default {
     this.$http.get('https://api.github.com/search/repositories?q=topic:epfl')
     .then((response) => {
       this.topics = response.data.items.sort((a, b) => {
-        if (a.stargazers_count == 0 && b.stargazers_count == 0) {
+        if (a.stargazers_count === 0 && b.stargazers_count === 0) {
           return b.stargazers_count - a.stargazers_count
-        } else {
+        }
+        else {
           return b.forks_count - b.forks_count
         }
       })
diff --git a/src/components/partials/Avatar.vue b/src/components/partials/Avatar.vue
index 87c9e95c..de659d5d 100644
--- a/src/components/partials/Avatar.vue
+++ b/src/components/partials/Avatar.vue
@@ -1,7 +1,7 @@
 <template lang="html">
-  <div class="avatar">
+  <span class="avatar">
     <a :href="dude.html_url"><img class="avatarimg" :src="dude.avatar_url" alt="" :width="size + 'px'" :title="dude.login" /><span v-if="login"> @{{ dude.login }}</span></a>
-  </div>
+  </span>
 </template>
 
 <script>
diff --git a/src/components/partials/EPFLTopic.vue b/src/components/partials/EPFLTopic.vue
index a9349ebb..2874bb83 100644
--- a/src/components/partials/EPFLTopic.vue
+++ b/src/components/partials/EPFLTopic.vue
@@ -20,9 +20,10 @@ export default {
 </script>
 <style>
 div.topic {
-  border: 1px solid lightgreen;
+  border-left: 1px solid lightgreen;
   border-radius: 4px;
-  margin: 20px;
+  padding: 5px;
+  margin: 15px;
   line-height: 2em;
 }
 </style>