Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: Text above reaction arrow ignores margins when atoms are added #2610

Closed
Zhirnoff opened this issue Nov 5, 2024 · 1 comment · Fixed by #2640
Closed

Preview: Text above reaction arrow ignores margins when atoms are added #2610

Zhirnoff opened this issue Nov 5, 2024 · 1 comment · Fixed by #2640
Assignees
Labels
Bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Nov 5, 2024

Steps to Reproduce

  1. Copy and Paste on canvas
$RDFILE 1
$DATM    11/05/24 15:07
$RFMT
$RXN

 -INDIGO- 1105241507

  2  1
$MOL

  -INDIGO-11052415072D

  1  0  0  0  0  0  0  0  0  0999 V2000
    7.6474   -4.4514    0.0000 O   0  0  0  0  0  0  0  0  0  0  0  0
M  END
$MOL

  -INDIGO-11052415072D

  1  0  0  0  0  0  0  0  0  0999 V2000
    7.3724   -6.9764    0.0000 O   0  0  0  0  0  0  0  0  0  0  0  0
M  END
$MOL

  -INDIGO-11052415072D

  1  0  0  0  0  0  0  0  0  0999 V2000
    9.9974   -5.7764    0.0000 N   0  0  0  0  0  0  0  0  0  0  0  0
M  END

$DTYPE Name
$DATUM Agrsthtyjyil9op98p90i6yrtrwwr6u579po9
$DTYPE Reference
$DATUM Not available
$DTYPE Reaction Conditions
$DATUM Agrsthtyjyil9op98p90i6yrtrwwr6u579po9

Actual behavior
Text above reaction arrow ignores margins when atoms are added

Expected behavior
The text should maintain proper margins above the arrow, with sufficient spacing as described in requrements.

Screenshots
2024-11-05_15h14_17

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.7]
Indigo version
[Version 1.27.0-dev.1]

Bug foun while pre-testing: #2559

@Zhirnoff Zhirnoff added Bug Priority: Medium MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Nov 5, 2024
@Zhirnoff Zhirnoff added this to the Indigo-1.26.0-rc.1 (Current) milestone Nov 5, 2024
@even1024 even1024 linked a pull request Nov 19, 2024 that will close this issue
7 tasks
@ivanmaslow ivanmaslow changed the title Text above reaction arrow ignores margins when atoms are added Preview: Text above reaction arrow ignores margins when atoms are added Nov 21, 2024
@ivanmaslow
Copy link
Collaborator

The fix is successfully verified on aws_ci SA env with Ketcher-master and Indigo-2404-ket-to-rdf branches:

  • Ketcher [Version 2.28.0-dev.1] Build at 2024-11-20; 19:58:39;
  • Indigo Version 1.27.0-dev.1.43-gec603913-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 131.0.6778.86 (Official Build) (64-bit)

Reaction's name and conditions are displayed correctly after save/load to/from RDF or layout actions:
image
Also, looks like it could fix #2610, but length of spine becomes bigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants