Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review json-rpc 2.0 implementation in request_handler.cpp #58

Open
elmato opened this issue Sep 13, 2023 · 1 comment
Open

Review json-rpc 2.0 implementation in request_handler.cpp #58

elmato opened this issue Sep 13, 2023 · 1 comment

Comments

@elmato
Copy link
Contributor

elmato commented Sep 13, 2023

In particular the supported types for id

spec:

id
An identifier established by the Client that MUST contain a String, Number, or NULL value if included. If it is not included it is assumed to be a notification. The value SHOULD normally not be Null [1] and Numbers SHOULD NOT contain fractional parts [2]

And the handling of invalid individual request inside a batch operation

@stephenpdeos
Copy link
Member

We should evaluate if the latest upstream Silkworm updates fix this issue. If not resolved, this will be managed as a lower priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants