Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR approver eligibility matrix #37

Open
stephenpdeos opened this issue Mar 18, 2023 · 0 comments
Open

PR approver eligibility matrix #37

stephenpdeos opened this issue Mar 18, 2023 · 0 comments
Labels
decision 🤔 An internal decision to made for eng team

Comments

@stephenpdeos
Copy link
Member

Our engineering team standard of requiring two approvals for any PR is good to have, but we need more clarity about who all is eligible to perform those approvals. We may wish to consider conditional roles for some contributors if they are the owner of a given feature set. One recent example would be to consider allowing Peter to be one of two reviewers to PRs related to performance harness since he has been technical lead on that project. A simple matrix of who is an eligible approver for what would make the review process go smoother in the future.
@stephenpdeos stephenpdeos added the decision 🤔 An internal decision to made for eng team label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision 🤔 An internal decision to made for eng team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephenpdeos