Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidity Token Price Calculations #172

Open
xavier506 opened this issue Sep 8, 2020 · 2 comments
Open

Liquidity Token Price Calculations #172

xavier506 opened this issue Sep 8, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@xavier506
Copy link
Member

xavier506 commented Sep 8, 2020

Calculate token prices for adding or removing liquidity so that users dont have to guess what the right amount of a token pair needs to be inputed to match the balance they want to transact.

image

@xavier506 xavier506 changed the title Price Calculations Liquidity Token Price Calculations Sep 8, 2020
@xavier506 xavier506 added this to the V1 milestone Sep 8, 2020
@murillojorge
Copy link
Member

I think we can incorporate a selector that enable the user to choose what kind of input and calculation to use.
Check it out here: https://app.zeplin.io/project/5ebb4f7439b0687707bf3078/dashboard?seid=5f610a4118d0ea7dec1e9afb
And let me know what you think please.

Mobile Liquidity - Dual

@xavier506 xavier506 assigned adriexnet and tetogomez and unassigned murillojorge Sep 29, 2020
@murillojorge
Copy link
Member

I want to open this issue for discussion.
When we started the project I thought that creating a single Add-Remove liquidity section would be the best option, mainly because of simplicity. At this stage because of the difference in fees, the resulting calculations and the single-dual input option, keeping Add and Remove together is no longer a good user experience.
My proposal is to have two sections and make it easier for the users to handle their liquidity.
You can take a look at the sections here:
https://app.zeplin.io/project/5ebb4f7439b0687707bf3078/dashboard?seid=5f610a4118d0ea7dec1e9afb
@xavier506 @tetogomez

@xavier506 xavier506 modified the milestones: V1, V2 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants