Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support History V2 API calls natively in the library #143

Open
liuxh-go opened this issue Jun 29, 2020 · 7 comments
Open

Support History V2 API calls natively in the library #143

liuxh-go opened this issue Jun 29, 2020 · 7 comments

Comments

@liuxh-go
Copy link

liuxh-go commented Jun 29, 2020

Can I set v1 in the method of assembling targetURL in eos.call as a parameter? I now want to use the URL of v2, which cannot be achieved with sdk

See: https://eos.hyperion.eosrio.io/v2/docs/index.html

@maoueh
Copy link
Contributor

maoueh commented Jun 29, 2020

@wshhz Can you point to any official documentation where /v2/ prefix is starting to be used? I'm not aware of any...

@liuxh-go
Copy link
Author

@maoueh
Copy link
Contributor

maoueh commented Jun 30, 2020

This is a new version of the API, it's most probable that simply changing v1 to v2 will not be enough to support the new version of the History API.

Happy to accept contributions that add support for v2 API calls. Note that we will not accept a simple change from v2 to v1, all v1 calls will need to exist until it's not supported anymore, which is not the case right now.

Would also accept exposing of raw method that would permit composition of "free-form" URL calls.

I'm going to change the title of the issue to reflect the request here.

@maoueh maoueh changed the title v1 was modified as a parameter in targetURL assembly Support History V2 API calls natively in the library (https://eos.hyperion.eosrio.io/v2/docs/index.html) Jun 30, 2020
@maoueh maoueh changed the title Support History V2 API calls natively in the library (https://eos.hyperion.eosrio.io/v2/docs/index.html) Support History V2 API calls natively in the library Jun 30, 2020
@liuxh-go
Copy link
Author

liuxh-go commented Jul 1, 2020

Please notify me after completing the modification, thank you!

@maoueh
Copy link
Contributor

maoueh commented Jul 2, 2020

Sorry, this is not something we are going to implement in the near future. If you need it, you will need to contribute or get a quote from us or another developer to integrate that.

@liuxh-go
Copy link
Author

liuxh-go commented Jul 3, 2020

ok

@liuxh-go liuxh-go closed this as completed Jul 3, 2020
@maoueh
Copy link
Contributor

maoueh commented Jul 3, 2020

Reopening to keep track of the feature request.

@maoueh maoueh reopened this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants