Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow All Icons to be Themed #352

Open
ochi12 opened this issue Nov 21, 2024 · 0 comments · May be fixed by #351
Open

Allow All Icons to be Themed #352

ochi12 opened this issue Nov 21, 2024 · 0 comments · May be fixed by #351

Comments

@ochi12
Copy link

ochi12 commented Nov 21, 2024 •
edited
Loading

Icons directly from Icons/ (not in Icons/hicolor/scalable/actions) cannot be themed because their Icon declaration in extensions.js are hard coded(doesn't implement system theme with fallback).

2024-11-21.08-36-51.mp4

PS: I for got to make an issue first before making a PR #351.
@ochi12 ochi12 changed the title Other Icons Can't be themed Allow All Icons to be Themed Nov 21, 2024
@ochi12 ochi12 linked a pull request Nov 21, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ochi12