Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some dependencies optional #116

Open
jtpio opened this issue Dec 12, 2024 · 1 comment
Open

Make some dependencies optional #116

jtpio opened this issue Dec 12, 2024 · 1 comment

Comments

@jtpio
Copy link

jtpio commented Dec 12, 2024

Thanks for putting this library together!

Currently there seems to be quite a few dependencies listed here:

python = ">=3.9,<4"
shiny = ">=0.7.0"
htmltools = ">=0.5.1"
jinja2 = ">=3.1.3"
pydantic = ">=2.5.3"
anywidget = ">=0.9.0"
pandas = {version = "^2.1.4", optional = true}
geopandas = {version = "^0.14.2", optional = true}

But it looks like some of them may not be necessary in some situations. For example JupyterLab users may not need the dependency on shiny.

So maybe it would be possible to move some of these to an extras group?

@jtpio
Copy link
Author

jtpio commented Dec 12, 2024

As a side-effect, this could help allow running maplibre in a WebAssembly environment like JupyterLite, which could then also enable some nice use cases such as hosting example notebooks on GitHub Pages, with everything running in the browser.

However it does not seem possible to install maplibre in JupyterLite at the moment when testing on https://jupyterlite.github.io/demo/lab/index.html, due to these extra dependencies:

import micropip
await micropip.install('maplibre', keep_going=True)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant