Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple vulnerabilties in glibc Docker containers #29688

Closed
phlax opened this issue Sep 19, 2023 · 18 comments
Closed

Multiple vulnerabilties in glibc Docker containers #29688

phlax opened this issue Sep 19, 2023 · 18 comments
Labels
area/docker area/release cve Security CVE issues stale stalebot believes this issue/PR has not been touched recently

Comments

@phlax
Copy link
Member

phlax commented Sep 19, 2023

There are 3 recent CVEs that appear to affect the glibc version in our Docker containers

I confirmed that our current distroless containers are vulnerable - its likely the case also with the Ubuntu containers (will confirm)

debian/ubuntu refs:

4527 appears to be medium severity and is yet to be confirmed

4813 has fixes for distroless at least - which is already on main - i have raised/updated backports for other branches

if the fix is there for ubuntu that will automatically get updated on next release/s

@phlax phlax added triage Issue requires triage cve Security CVE issues area/docker area/release and removed triage Issue requires triage labels Sep 19, 2023
@phlax
Copy link
Member Author

phlax commented Sep 19, 2023

cc @javabypatel

@phlax
Copy link
Member Author

phlax commented Sep 26, 2023

@suniltheta
Copy link
Contributor

suniltheta commented Sep 26, 2023

Update: Seems unrelated, created a new issue #29902


I see a NACK thrown in Envoy version v1.27 (very rarely).

failureReason:Error adding/updating listener(s) egress: malformed IP address: 2600:f0f0:0:0:0:0:0:1

As per NACK Envoy couldn't validate that this is a proper IPv6 address which was provided in filter chain match like

         "filter_chain_match": {
          "prefix_ranges": [
           {
            "address_prefix": "127.255.0.1",
            "prefix_len": 32
           },
           {
            "address_prefix": "2600:f0f0:0:0:0:0:0:1",
            "prefix_len": 128
           }
          ],

I believe the IPv6 address validation is done in

const Api::SysCallIntResult rc = Api::OsSysCallsSingleton::get().getaddrinfo(


Given that the CVE's report issue with getaddrinfo function, can I expect that this issue might be related?

@phlax
Copy link
Member Author

phlax commented Oct 4, 2023

incoming issue here GoogleContainerTools/distroless#1420 which is resolved by GoogleContainerTools/distroless#1419

will update the containers when they release (i would expect today)

@phlax
Copy link
Member Author

phlax commented Oct 5, 2023

i have updated the distroless base to latest and have pending backports for it - but just saw ...

GoogleContainerTools/distroless#1422

@loosebazooka
Copy link

I think this is actually fine. The latest distroless/base should not have the high critical cve on libc6.

FYI though, we have distroless/base-nossl-debian12 now which I would recommend over debian11 if that works with your builds.

@moderation
Copy link
Contributor

FYI though, we have distroless/base-nossl-debian12 now which I would recommend over debian11 if that works with your builds.

It would be good to bump to this newer Debian 12 version 👍

@phlax
Copy link
Member Author

phlax commented Oct 9, 2023

It would be good to bump to this newer Debian 12 version 👍

my thought had been to wait until this batch of releases is out of the way, altho tbh i dont see any reason we cant upgrade now

@phlax
Copy link
Member Author

phlax commented Oct 9, 2023

PR is here #30029

@marcosrmendezthd
Copy link
Contributor

looks like we've released new versions. wonder why the CVEs were not mentioned in the release notes.

@phlax
Copy link
Member Author

phlax commented Oct 12, 2023

they were alluded to - as these were upstream vulns i thought it less important to list out any issues that were resolved

docker/publishing: Update base images to resolve various glibc vulnerabilities.

https://www.envoyproxy.io/docs/envoy/latest/version_history/v1.27/v1.27.1

and on the release pages

altho just spotted this is missing from the (pending) current changelog

@phlax
Copy link
Member Author

phlax commented Oct 12, 2023

main changelog update is here #30144

@marcosrmendezthd
Copy link
Contributor

ah we're still on 1.26. didn't see it on https://www.envoyproxy.io/docs/envoy/latest/version_history/v1.26/v1.26.5. thanks @phlax

@phlax
Copy link
Member Author

phlax commented Oct 12, 2023

i think it got missed on that branch - trying to improve these workflows atm

@phlax
Copy link
Member Author

phlax commented Oct 12, 2023

(just to clarify - just the changelog was missed)

@phlax
Copy link
Member Author

phlax commented Oct 13, 2023

@javabypatel you can see the current versions that are being used by checking the pins in the Dockerfilie - eg on main

https://github.com/envoyproxy/envoy/blob/main/ci/Dockerfile-envoy

i try to keep these in sync across all branches

in terms of outstanding CVEs these are generally the latest available upstream so incorporate anything currently actionable

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 12, 2023
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker area/release cve Security CVE issues stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

5 participants