Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertCell throws "TypeError: Cannot read property 'nodeName' of null" #10

Open
orslumen opened this issue Mar 18, 2011 · 1 comment
Open

Comments

@orslumen
Copy link

First of all, thank you for the great work on envjs!

While upgrading our integration tests from envjs 0.3.7 to 1.3.pre1 I noticed that when insertCell (html.js) is called with idx === numCells an error is thrown, because node is null when passed to insertBefore.

To fix this, the line this.insertBefore(cell, node); needs to be placed 2 lines higher within the else block. So the new cell is either appended at the end of the row, or inserted before an existing cell.

Kind regards,
Orslumen

PS. If you prefer a pull request, pls let me know.

@thatcher
Copy link
Collaborator

this is perfect, thank you for adding tickets!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants