From ebfa731d3e928526be761d2ed2db74cef4edec6e Mon Sep 17 00:00:00 2001 From: Isaiah Thomason <47364027+ITenthusiasm@users.noreply.github.com> Date: Wed, 27 Dec 2023 19:13:46 -0500 Subject: [PATCH] chore: Don't Type Check `.d.ts` Files The TypeScript type checker is now throwing errors when we check types with the `skipLibCheck: false` configuration. It seems that one of the packages that we installed along the way started causing this problem... Vitest definitely seems to be a culprit. We can't ignore this anymore since we're thinking about adding linting to CI. Generally speaking, this should be fine. But we DO want to make sure that our LOCAL `.d.ts` files are accurate. So... if necessary, we may occasionally need to make this flag `false` to make sure things are behaving as expected -- unless we find that TS will still check our LOCAL `.d.ts` files. In an ideal world, we could define all of our types in JS files. Hopefully that day comes eventually. Then we wouldn't need to worry about this problem either way. :smile: --- tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tsconfig.json b/tsconfig.json index 09ca891..9453ee6 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -12,7 +12,7 @@ "declaration": true, "esModuleInterop": true, "forceConsistentCasingInFileNames": true, - "skipLibCheck": false + "skipLibCheck": true }, // TODO: Split Vitest Config out from final production bundle ... EDIT: Depends on comment above "include": ["packages/**/*", "scripts/**/*", "vitest.config.ts", "vitest.workspace.ts"]