From 686c207225f45e98ff0aaf51529dd782b33998de Mon Sep 17 00:00:00 2001 From: Isaiah Thomason <47364027+ITenthusiasm@users.noreply.github.com> Date: Sun, 5 Nov 2023 08:04:45 -0500 Subject: [PATCH] chore: Enable Test for `autoObserve` in Solid Integration The test actually _was not_ failing due to a bug in Vitest or Solid Testing Library. This test was actually (rightly) failing because of solidjs/solid-docs#278. This bug has been fixed by fdf61ed680c1f464000d297a700ec84d7b745b17. --- packages/solid/__tests__/createFormValidityObserver.test.tsx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/solid/__tests__/createFormValidityObserver.test.tsx b/packages/solid/__tests__/createFormValidityObserver.test.tsx index 1fca1b8..48cc035 100644 --- a/packages/solid/__tests__/createFormValidityObserver.test.tsx +++ b/packages/solid/__tests__/createFormValidityObserver.test.tsx @@ -118,10 +118,7 @@ describe("Create Form Validity Observer (Function)", () => { describe("Returned Interface", () => { describe("autoObserve (Method)", () => { - // TODO: This test is currently broken because of issues either with `@solidjs/testing-library` or `vitest` or both. - // This test is important, but unfortunately it's impossible right now. Let's see what we can do in the future. - // eslint-disable-next-line vitest/no-disabled-tests - it.skip("Automatically sets up the `FormValidityObserver` (onMount) and cleans it up (onUnmount)", async () => { + it("Automatically sets up the `FormValidityObserver` (onMount) and cleans it up (onUnmount)", async () => { /* ---------- Setup ---------- */ const message = "Only numbers are allowed!"; vi.spyOn(FormValidityObserver.prototype, "observe");