Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] App crashing when loading faulty theme URL #25

Open
singlekeycap opened this issue Sep 6, 2022 · 7 comments
Open

[Bug] App crashing when loading faulty theme URL #25

singlekeycap opened this issue Sep 6, 2022 · 7 comments

Comments

@singlekeycap
Copy link

When adding a theme URL that 404's or just doesn't work, the theme obviously isn't added to the list. The issue arises when you reopen the app, and the app crashes. I'm on iOS 15.1.1 using Enmity 2.1.3 sideloaded with TrollStore 1.0.7.

Steps to reproduce:

  1. Enter URL for a theme that 404's/is broken.
  2. Close the app
  3. Reopen the app
  4. Profit......?
@singlekeycap
Copy link
Author

To add to this issue: anytime a theme is overwritten, if the version number is the same Enmity will not update it. Even deleting the theme and re-adding it will do nothing.

@imyanice
Copy link
Contributor

To add to this issue: anytime a theme is overwritten, if the version number is the same Enmity will not update it. Even deleting the theme and re-adding it will do nothing.

You can force delete and install a theme using the iOS files app (Files>On my iPhone>Enmity>Themes then delete the plugin you wanna delete ~obviously)

@singlekeycap
Copy link
Author

@Yan-Jobs Sure that works, but it shouldn't be a problem in the first place.

@imyanice
Copy link
Contributor

@Yan-Jobs Sure that works, but it shouldn't be a problem in the first place.

The devs are doing this in their spare time don’t blame them if it’s buggy :/

@singlekeycap
Copy link
Author

I'm not blaming anyone, I just opened this issue to let them know. Never expected it to be fixed at any point in the near future.

@imyanice
Copy link
Contributor

I'm not blaming anyone, I just opened this issue to let them know. Never expected it to be fixed at any point in the near future.

👍

@imyanice
Copy link
Contributor

The thing is I don’t really get how the themes are handled. I see that through modules/native.ts, the sendCommand option is just opening an url which is parsed with a decodeUriComponent. BUT I can’t understand what’s going on behind the curtains on how the theme file is deleted. Maybe @localip could explain me how the file is deleted to work on a fix ?
- Yan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@singlekeycap @imyanice and others