Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.google.android.exoplayer2.video.VideoListener was removed in ExoPlayer 2.16.0, making this library incompatible #505

Open
1 task done
sal0max opened this issue Jan 16, 2022 · 2 comments

Comments

@sal0max
Copy link

sal0max commented Jan 16, 2022

What kind of issue is this?

  • Bug report. If so, please supply the way to reproduce the issue, including addition information as follow:
    • Toro version: 3.7.0.2010003
    • ExoPlayer version: >= 2.16.0

im.ene.toro.exoplayer.Playable imports and uses com.google.android.exoplayer2.video.VideoListener (link), which was removed in ExoPlayer 2.16.0 (see changelog)

In order for this library to work again, you need to follow this advice:

Remove SimpleExoPlayer.addVideoListener, removeVideoListener and VideoListener. Use Player.addListener and Player.Listener instead.

@manumuuv
Copy link

Any update on this?
Did you find any solution to this issue?
ExoPlayer 2.16.0+ is needed to target Android 12+, otherwise, the app will crash, so I think toro should support ExoPlayer version: >= 2.16.0 asap.

@BenCherif
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants