From 51f019eba66f4b8a65b4652338e3c2681b3bcbec Mon Sep 17 00:00:00 2001
From: Dan Nicholson <dbn@endlessos.org>
Date: Tue, 14 Nov 2023 13:29:03 -0700
Subject: [PATCH] ImageBuildRoot: Bring back apt cache directory

Since `mmdebstrap` is no longer being used, a populated apt cache
directory can be mounted into the buildroot and the packages there will
be reused instead of being downloaded again. This is essentially a
revert of 1f7e15403a5e3525d81a69e8a33b4c64d8f5930c.
---
 run-build | 33 +++++++++++++++------------------
 1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/run-build b/run-build
index 52a78ba3..eb763a2e 100755
--- a/run-build
+++ b/run-build
@@ -52,8 +52,8 @@ class ImageBuildRoot(object):
         # Get the config parameters
         packages = config['buildroot']['packages'].split()
         config_mounts = config['buildroot']['mounts'].split()
-        # aptcache_dir = config['buildroot']['aptcache_dir']
-        # aptcache_max_size = int(config['buildroot']['aptcache_max_size'])
+        aptcache_dir = config['buildroot']['aptcache_dir']
+        aptcache_max_size = int(config['buildroot']['aptcache_max_size'])
 
         # Build a list of required mounts using configuration values
         required_mounts = [
@@ -68,6 +68,7 @@ class ImageBuildRoot(object):
             # Required builder directories
             config['build']['cachedir'],
             config['build']['srcdir'],
+            aptcache_dir,
         ]
 
         # Optional mounts dependent on existence on the host
@@ -80,19 +81,13 @@ class ImageBuildRoot(object):
             required_mounts.append(config['build']['localdir'])
 
         # Wipe the apt cache directory if it's grown too large.
-        #
-        # FIXME: This is currently commented because mmdebstrap throws
-        # an error if you seed /var/cache/apt/archives in the root
-        # before it runs. To make this work something like apt-cacher is
-        # needed to handle it at the HTTP level.
-        #
-        # if os.path.exists(aptcache_dir):
-        #     aptcache_size = eib.disk_usage(aptcache_dir)
-        #     if aptcache_size >= aptcache_max_size:
-        #         log.info('Apt cache directory uses %d bytes, removing',
-        #                  aptcache_size)
-        #         shutil.rmtree(aptcache_dir)
-        # os.makedirs(os.path.join(aptcache_dir), exist_ok=True)
+        if os.path.exists(aptcache_dir):
+            aptcache_size = eib.disk_usage(aptcache_dir)
+            if aptcache_size >= aptcache_max_size:
+                log.info('Apt cache directory uses %d bytes, removing',
+                         aptcache_size)
+                shutil.rmtree(aptcache_dir)
+        os.makedirs(aptcache_dir, exist_ok=True)
 
         # Pull the ostree. Ideally the eosminbase ostree would be used to
         # minimize the buildroot, but that's not released and would fail with
@@ -184,7 +179,7 @@ class ImageBuildRoot(object):
         apt_conf_path = os.path.join(self.builddir, 'etc/apt/apt.conf.d/99eib.conf')
         os.makedirs(os.path.dirname(apt_conf_path), exist_ok=True)
         with open(apt_conf_path, 'w') as f:
-            f.write(dedent("""\
+            f.write(dedent(f"""\
             # Assume yes for all apt questions.
             APT::Get::Assume-Yes "true";
             # Disable recommends like when building the OS.
@@ -193,10 +188,12 @@ class ImageBuildRoot(object):
             Acquire::AllowReleaseInfoChange "true";
             # Don't fetch any translations.
             Acquire::Languages "none";
-            DPkg::Options {
+            # Use our apt archive cache.
+            Dir::Cache::archives "{aptcache_dir}/";
+            DPkg::Options {{
                 # Always use the new version of a config file when upgrading.
                 "--force-confnew";
-            };
+            }};
             """))
         apt_cmd = ['chroot', self.builddir, 'apt-get', 'update']
         subprocess.check_call(apt_cmd, env=apt_env)