Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-wartremover, wartremover to 3.2.2 #375

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Update sbt-wartremover, wartremover to 3.2.2 #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a81cfbb
Update sbt-wartremover, wartremover to 3.2.2
scala-steward Oct 8, 2024
a975842
Add wartremover warning suppression for false positive in Availabilit…
Oct 10, 2024
0a9fc99
Simplify log entry in example
Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions example/src/main/scala/endless/example/app/impl/Availabilities.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import java.time.Instant
import scala.concurrent.duration.*

trait Availabilities {
@SuppressWarnings(Array("org.wartremover.warts.ToString"))
implicit def alwaysAvailable[F[_]: Logger: Monad: Async]: AvailabilityAlg[F] =
(time: Instant, passengerCount: Int) =>
Logger[F].info(
Expand Down
7 changes: 3 additions & 4 deletions example/src/main/scala/endless/example/logic/BookingEntityBehavior.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,9 @@ final case class BookingEntityBehavior[F[_]: Logger: Clock](
booking.status match {
case Status.Accepted | Status.Pending =>
EitherT.liftF(
(Clock[F].realTimeInstant >>= (timestamp =>
Logger[F]
.info(show"Cancelling booking with ID ${booking.id} at ${timestamp.toString}")
)) >> entity.write(BookingCancelled)
Logger[F].info(show"Cancelling booking with ID ${booking.id}") >> entity.write(
BookingCancelled
)
)
case Status.Cancelled => EitherT.pure(())
case Status.Rejected => EitherT.leftT[F, Unit](BookingAlg.BookingWasRejected(booking.id))
Expand Down
2 changes: 1 addition & 1 deletion project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
addSbtPlugin("org.wartremover" % "sbt-wartremover" % "3.2.0")
addSbtPlugin("org.wartremover" % "sbt-wartremover" % "3.2.2")
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.1.1")
addSbtPlugin("ch.epfl.scala" % "sbt-version-policy" % "3.2.1")
addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.7.0")
Expand Down
Loading