Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dol diff: Conditionally warn on symbol size mismatch #35

Open
encounter opened this issue Jan 24, 2024 · 0 comments
Open

dol diff: Conditionally warn on symbol size mismatch #35

encounter opened this issue Jan 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@encounter
Copy link
Owner

encounter commented Jan 24, 2024

Right now, a symbol size mismatch will error and halt the diff. This is annoying for symbols where the true size was discovered and symbols.txt hasn't yet been updated to reflect. If the next symbol is still at the correct address (meaning that alignment was not broken), omit a warning instead and continue.

@encounter encounter changed the title ninja diff: Conditionally warn on symbol size mismatch dol diff: Conditionally warn on symbol size mismatch Jan 24, 2024
@encounter encounter added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant