Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of fixed-point types #47

Open
clangenb opened this issue Feb 23, 2022 · 0 comments
Open

Proper handling of fixed-point types #47

clangenb opened this issue Feb 23, 2022 · 0 comments

Comments

@clangenb
Copy link
Member

Currently we have defined our fixed point types like:

BalanceType: i128

but what is returned from the chain is:

BalanceTypeChain: {
     bits: i128
}

We need to somehow align this properly such that:

  • To the outside; the developer does not see a difference, whether he is using encointer-js or polkadot-js/api directly.

Which basically means that we need to change the encointer-js code to BalanceTypeChain as arguments and return values of its function.

We need to update the code at several places to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant